summaryrefslogtreecommitdiff
path: root/refs.c
diff options
context:
space:
mode:
authorLibravatar Ævar Arnfjörð Bjarmason <avarab@gmail.com>2021-03-28 15:15:46 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-03-28 19:03:10 -0700
commit394d5d31b0d3096aed4513bdacf48fb73003f1df (patch)
tree9860250512b34cc93a11be0da1540ddbe1e0f3f7 /refs.c
parentfsck.[ch]: move FOREACH_FSCK_MSG_ID & fsck_msg_id from *.c to *.h (diff)
downloadtgif-394d5d31b0d3096aed4513bdacf48fb73003f1df.tar.xz
fsck.c: pass along the fsck_msg_id in the fsck_error callback
Change the fsck_error callback to also pass along the fsck_msg_id. Before this change the only way to get the message id was to parse it back out of the "message". Let's pass it down explicitly for the benefit of callers that might want to use it, as discussed in [1]. Passing the msg_type is now redundant, as you can always get it back from the msg_id, but I'm not changing that convention. It's really common to need the msg_type, and the report() function itself (which calls "fsck_error") needs to call fsck_msg_type() to discover it. Let's not needlessly re-do that work in the user callback. 1. https://lore.kernel.org/git/87blcja2ha.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs.c')
0 files changed, 0 insertions, 0 deletions