diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-09-08 03:08:03 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-09-07 22:04:03 -0700 |
commit | 8fe8bae9d28e2b02ceb482ab89ea88bb20556f1d (patch) | |
tree | bfc00915ffb921352658d2ac9312a9d695bfcac5 /ref-filter.h | |
parent | Git 2.32 (diff) | |
download | tgif-8fe8bae9d28e2b02ceb482ab89ea88bb20556f1d.tar.xz |
pack-write: skip *.rev work when not writing *.rev
Fix a performance regression introduced in a587b5a786 (pack-write.c:
extract 'write_rev_file_order', 2021-03-30) and stop needlessly
allocating the "pack_order" array and sorting it with
"pack_order_cmp()", only to throw that work away when we discover that
we're not writing *.rev files after all.
This redundant work was not present in the original version of this
code added in 8ef50d9958 (pack-write.c: prepare to write 'pack-*.rev'
files, 2021-01-25). There we'd call write_rev_file() from
e.g. finish_tmp_packfile(), but we'd "return NULL" early in
write_rev_file() if not doing a "WRITE_REV" or "WRITE_REV_VERIFY".
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ref-filter.h')
0 files changed, 0 insertions, 0 deletions