diff options
author | Jeff King <peff@peff.net> | 2020-11-04 14:28:31 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-11-04 14:05:28 -0800 |
commit | 4c6f781f9c7ee7029c3f2fd20ddd76ce8b476bca (patch) | |
tree | bb2b99abdf85a596bc7cbc7695e3fbf9e8984f38 /rebase.c | |
parent | Git 2.29.2 (diff) | |
download | tgif-4c6f781f9c7ee7029c3f2fd20ddd76ce8b476bca.tar.xz |
format-patch: refactor output selection
The --stdout and --output-directory options are mutually exclusive, but
it's hard to tell from reading the code. We have three separate
conditionals that check for use_stdout, and it's only after we've set up
the output_directory fully that we check whether the user also specified
--stdout.
Instead, let's check the exclusion explicitly first, then have a single
conditional that handles stdout versus an output directory. This is
slightly easier to follow now, and also will keep things sane when we
add another output mode in a future patch.
We'll add a few tests as well, covering the mutual exclusion and the
fact that we are not confused by a configured output directory.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'rebase.c')
0 files changed, 0 insertions, 0 deletions