summaryrefslogtreecommitdiff
path: root/rebase-interactive.h
diff options
context:
space:
mode:
authorLibravatar Todd Zullinger <tmz@pobox.com>2019-11-29 19:46:53 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-12-01 22:09:07 -0800
commite714b898c68c665227930ef3b68cf1acb7d07f3e (patch)
treee1fc72d488990f665fcd89e96c2aae2dee482ab9 /rebase-interactive.h
parentt7812: add missing redirects (diff)
downloadtgif-e714b898c68c665227930ef3b68cf1acb7d07f3e.tar.xz
t7812: expect failure for grep -i with invalid UTF-8 data
When the 'grep with invalid UTF-8 data' tests were added/adjusted in 8a5999838e (grep: stess test PCRE v2 on invalid UTF-8 data, 2019-07-26) and 870eea8166 (grep: do not enter PCRE2_UTF mode on fixed matching, 2019-07-26) they lacked a redirect which caused them to falsely succeed on most systems. The 'grep -i' test failed on systems where JIT was disabled as it never reached the portion which was missing the redirect. A recent patch added the missing redirect and exposed the fact that the 'PCRE v2: grep non-ASCII from invalid UTF-8 data with -i' test fails regardless of whether JIT is enabled. Based on the final paragraph in in 870eea8166: When grepping a non-ASCII fixed string. This is a more general problem that's hard to fix, but we can at least fix the most common case of grepping for a fixed string without "-i". I can't think of a reason for why we'd turn on PCRE2_UTF when matching byte-for-byte like that. it seems that we don't expect that the case-insensitive grep will succeed. Adjust the test to reflect that expectation. Signed-off-by: Todd Zullinger <tmz@pobox.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'rebase-interactive.h')
0 files changed, 0 insertions, 0 deletions