summaryrefslogtreecommitdiff
path: root/reachable.c
diff options
context:
space:
mode:
authorLibravatar Stephen Boyd <bebarino@gmail.com>2009-10-08 23:21:44 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2009-10-09 15:00:40 -0700
commite0d78059540aab2e6ff720e7c940d7244cc12c18 (patch)
treef61f3f6d994a03875e0a241eab8379898ec314f7 /reachable.c
parentcompletion: fix completion of git <TAB><TAB> (diff)
downloadtgif-e0d78059540aab2e6ff720e7c940d7244cc12c18.tar.xz
completion: fix alias listings with newlines
Aliases with newlines have been a problem since commit 56fc25f (Bash completion support for remotes in .git/config., 2006-11-05). The chance of the problem occurring has been slim at best, until commit 518ef8f (completion: Replace config --list with --get-regexp, 2009-09-11) removed the case statement introduced by commit 56fc25f. Before removing the case statement, most aliases with newlines would work unless they were specially crafted as follows [alias] foo = "log -1 --pretty='format:%s\nalias.error=broken'" After removing the case statement, a more benign alias like [alias] whowhat = "log -1 --pretty='format:%an <%ae>\n%s'" wont-complete = ... would cause the completion to break badly. For now, revert the removal of the case statement until someone comes up with a better way to get keys from git-config. Signed-off-by: Stephen Boyd <bebarino@gmail.com> Acked-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'reachable.c')
0 files changed, 0 insertions, 0 deletions