diff options
| author |  Karsten Blees <blees@dcon.de> | 2014-11-27 00:24:01 -0500 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-11-30 18:07:34 -0800 |
| commit | b5007211b6582fc38647ff695b5ac51541ea9de8 (patch) | |
| tree | 4208da1ac8c0929519656f951f43384e8970fa5c /progress.c | |
| parent | ewah_bitmap.c: do not assume size_t and eword_t are the same size (diff) | |
| download | tgif-b5007211b6582fc38647ff695b5ac51541ea9de8.tar.xz | |
pack-bitmap: do not use gcc packed attribute
The "__attribute__" flag may be a noop on some compilers.
That's OK as long as the code is correct without the
attribute, but in this case it is not. We would typically
end up with a struct that is 2 bytes too long due to struct
padding, breaking both reading and writing of bitmaps.
Instead of marshalling the data in a struct, let's just
provide helpers for reading and writing the appropriate
types. Besides being correct on all platforms, the result is
more efficient and simpler to read.
Signed-off-by: Karsten Blees <blees@dcon.de>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'progress.c')
0 files changed, 0 insertions, 0 deletions