summaryrefslogtreecommitdiff
path: root/ppc/sha1.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2015-08-06 01:33:57 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-08-07 11:52:46 -0700
commit9b5fe78b343d2416e5c6da28fa80303957aec371 (patch)
treea1929ac2c6b390d6cc5fa3ec4bb1691a1bdfc413 /ppc/sha1.c
parenttest-lib: turn off "-x" tracing during chain-lint check (diff)
downloadtgif-9b5fe78b343d2416e5c6da28fa80303957aec371.tar.xz
test-lib: disable trace when test is not verbose
The "-x" test-script option turns on the shell's "-x" tracing, which can help show why a particular test is failing. Unfortunately, this can create false negatives in some tests if they invoke a shell function with its stderr redirected. t5512.10 is such a test, as it does: test_must_fail git ls-remote refs*master >actual 2>&1 && test_cmp exp actual The "actual" file gets the "-x" trace for the test_must_fail function, which prevents it from matching the expected output. There's no way to avoid this without managing the trace flag inside each sub-function, which isn't really a workable solution. But unless you specifically care about t5512.10, we can work around it by enabling tracing only for the specific tests we want. You can already do: ./t5512-ls-remote.sh -x --verbose-only=16 to see the trace only for a specific test. But that doesn't _disable_ the tracing in the other tests; it just sends it to /dev/null. However, there's no point in generating a trace that the user won't see, so we can simply disable tracing whenever it doesn't have a matching verbose flag. The normal case of just "./t5512-ls-remote.sh -x" stays the same, as "-x" already implies "--verbose" (and "--verbose-only" overrides "--verbose", which is why this works at all). And for our test, we need only check $verbose, as maybe_setup_verbose will have already set that flag based on the $verbose_only list). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ppc/sha1.c')
0 files changed, 0 insertions, 0 deletions