summaryrefslogtreecommitdiff
path: root/perl
diff options
context:
space:
mode:
authorLibravatar Matthieu Moy <Matthieu.Moy@imag.fr>2016-10-21 11:20:24 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-10-21 09:48:26 -0700
commitdcfafc5214e6af277aa8565af4f63b20046d65bf (patch)
tree8ce9fa64cdf7687eeecfd21d0d57153fb479dfa5 /perl
parentt9000-addresses: update expected results after fix (diff)
downloadtgif-dcfafc5214e6af277aa8565af4f63b20046d65bf.tar.xz
Git.pm: add comment pointing to t9000
parse_mailboxes should probably eventually be completely equivalent to Mail::Address, and if this happens we can drop the Mail::Address dependency. Add a comment in the code reminding the current state of the code, and point to the corresponding failing test to help future contributors to get it right. Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'perl')
-rw-r--r--perl/Git.pm2
1 files changed, 2 insertions, 0 deletions
diff --git a/perl/Git.pm b/perl/Git.pm
index 42e0895ef7..8bb2b7c7e3 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -870,6 +870,8 @@ Return an array of mailboxes extracted from a string.
=cut
+# Very close to Mail::Address's parser, but we still have minor
+# differences in some cases (see t9000 for examples).
sub parse_mailboxes {
my $re_comment = qr/\((?:[^)]*)\)/;
my $re_quote = qr/"(?:[^\"\\]|\\.)*"/;