diff options
| author |  Junio C Hamano <gitster@pobox.com> | 2008-05-27 23:33:22 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-05-27 23:35:55 -0700 |
| commit | d683a0e00cd4734b4fab704baef1ee76205722be (patch) | |
| tree | 5bd68609cb1d489f83455bda25200d4050415fd7 /perl | |
| parent | t5100: Avoid filename "nul" (diff) | |
| download | tgif-d683a0e00cd4734b4fab704baef1ee76205722be.tar.xz | |
Git::cat_blob: allow using an empty blob to fix git-svn breakage
Recent "git-svn optimization" series introduced Git::cat_blob() subroutine
whose interface was broken in that it returned the size of the blob but
signalled an error by returning 0. You can never use an empty blob with
such an interface.
This fixes the interface to return a negative value to signal an error.
Reported by Björn Steinbrink.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'perl')
| -rw-r--r-- | perl/Git.pm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/perl/Git.pm b/perl/Git.pm index 6ba8ee5c0d..d05b633b64 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -811,12 +811,12 @@ sub cat_blob { my $description = <$in>; if ($description =~ / missing$/) { carp "$sha1 doesn't exist in the repository"; - return 0; + return -1; } if ($description !~ /^[0-9a-fA-F]{40} \S+ (\d+)$/) { carp "Unexpected result returned from git cat-file"; - return 0; + return -1; } my $size = $1; |