diff options
| author |  Petr Baudis <pasky@suse.cz> | 2007-05-09 12:49:41 +0200 |
|---|---|---|
| committer |  Junio C Hamano <junkio@cox.net> | 2007-05-10 14:13:29 -0700 |
| commit | 35c49eeae7e71e8554f27958a16405397c69b552 (patch) | |
| tree | 3cf797fe55167e326c8b9f74b99317918b5da2b3 /perl | |
| parent | Merge branch 'maint' (diff) | |
| download | tgif-35c49eeae7e71e8554f27958a16405397c69b552.tar.xz | |
Git.pm: config_boolean() -> config_bool()
This patch renames config_boolean() to config_bool() for consistency with
the commandline interface and because it is shorter but still obvious. ;-)
It also changes the return value from some obscure string to real Perl
boolean, allowing for clean user code.
Signed-off-by: Petr Baudis <pasky@suse.cz>
Diffstat (limited to 'perl')
| -rw-r--r-- | perl/Git.pm | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/perl/Git.pm b/perl/Git.pm index b5b1cf5edc..8fd3611753 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -516,9 +516,11 @@ sub config { } -=item config_boolean ( VARIABLE ) +=item config_bool ( VARIABLE ) -Retrieve the boolean configuration C<VARIABLE>. +Retrieve the bool configuration C<VARIABLE>. The return value +is usable as a boolean in perl (and C<undef> if it's not defined, +of course). Must be called on a repository instance. @@ -526,14 +528,16 @@ This currently wraps command('config') so it is not so fast. =cut -sub config_boolean { +sub config_bool { my ($self, $var) = @_; $self->repo_path() or throw Error::Simple("not a repository"); try { - return $self->command_oneline('config', '--bool', '--get', + my $val = $self->command_oneline('config', '--bool', '--get', $var); + return undef unless defined $val; + return $val eq 'true'; } catch Git::Error::Command with { my $E = shift; if ($E->value() == 1) { |