diff options
author | Jeff King <peff@peff.net> | 2013-04-05 18:22:15 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-04-06 18:56:45 -0700 |
commit | de89f0b25a42238948787421c0253228c006f7fa (patch) | |
tree | 295204103fdc6d9314f23ec0c4d4ba138abcbf01 /parse-options-cb.c | |
parent | http: re-word http error message (diff) | |
download | tgif-de89f0b25a42238948787421c0253228c006f7fa.tar.xz |
remote-curl: die directly with http error messages
When we encounter an unknown http error (e.g., a 403), we
hand the error code to http_error, which then prints it with
error(). After that we die with the redundant message "HTTP
request failed".
Instead, let's just drop http_error entirely, which does
nothing but pass arguments to error(), and instead die
directly with a useful message.
So before:
$ git clone https://example.com/repo.git
Cloning into 'repo'...
error: unable to access 'https://example.com/repo.git': The requested URL returned error: 403 Forbidden
fatal: HTTP request failed
and after:
$ git clone https://example.com/repo.git
Cloning into 'repo'...
fatal: unable to access 'https://example.com/repo.git': The requested URL returned error: 403 Forbidden
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'parse-options-cb.c')
0 files changed, 0 insertions, 0 deletions