summaryrefslogtreecommitdiff
path: root/pack-objects.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2015-08-10 05:35:49 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-08-10 15:37:12 -0700
commitb21a5d66055e0a446e61a12d540406f2757f6263 (patch)
treefcabbff3d8c936d0ac082cfc9667c805ef2a553a /pack-objects.c
parentprefer mkpathdup to mkpath in assignments (diff)
downloadtgif-b21a5d66055e0a446e61a12d540406f2757f6263.tar.xz
remote.c: drop extraneous local variable from migrate_file
It's an anti-pattern to assign the result of git_path to a variable, since other calls may reuse our buffer. In this case, we feed the result to unlink_or_warn immediately afterwards, so it's OK. However, it's nice to avoid assignment entirely, which makes it more obvious that there's no bug. We can just pass the result directly to unlink_or_warn, which is a known-simple function. As a bonus, the code flow is a little more obvious, as we eliminate an extra conditional (a reader does not have to wonder any more "under which circumstances is 'path' set?"). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-objects.c')
0 files changed, 0 insertions, 0 deletions