diff options
| author |  Sun He <sunheehnus@gmail.com> | 2014-03-03 17:39:59 +0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-03-06 14:03:12 -0800 |
| commit | 50546b15ed1df25837f8b291e6fa5bbcdb84635e (patch) | |
| tree | b2e93edbd6dd402b3a771173d5194adbdb5c235f /pack-bitmap-write.c | |
| parent | Merge branch 'maint' (diff) | |
| download | tgif-50546b15ed1df25837f8b291e6fa5bbcdb84635e.tar.xz | |
Use hashcpy() when copying object names
We invented hashcpy() to keep the abstraction of "object name"
behind it. Use it instead of calling memcpy() with hard-coded
20-byte length when moving object names between pieces of memory.
Leave ppc/sha1.c as-is, because the function is about the SHA-1 hash
algorithm whose output is and will always be 20 bytes.
Helped-by: Michael Haggerty <mhagger@alum.mit.edu>
Helped-by: Duy Nguyen <pclouds@gmail.com>
Signed-off-by: Sun He <sunheehnus@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pack-bitmap-write.c')
| -rw-r--r-- | pack-bitmap-write.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pack-bitmap-write.c b/pack-bitmap-write.c index 1218befaf2..5f1791a59c 100644 --- a/pack-bitmap-write.c +++ b/pack-bitmap-write.c @@ -530,7 +530,7 @@ void bitmap_writer_finish(struct pack_idx_entry **index, header.version = htons(default_version); header.options = htons(flags | options); header.entry_count = htonl(writer.selected_nr); - memcpy(header.checksum, writer.pack_checksum, 20); + hashcpy(header.checksum, writer.pack_checksum); sha1write(f, &header, sizeof(header)); dump_bitmap(f, writer.commits); |