diff options
| author |  Matthieu Moy <git@matthieu-moy.fr> | 2017-08-23 12:21:02 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-08-24 14:40:17 -0700 |
| commit | cc9075067776ebd34cc08f31bf78bb05f12fd879 (patch) | |
| tree | 9e7bd9e13aeb9a2d79cebbf0af76b03fe8b1a1c9 /notes.c | |
| parent | send-email: fix garbage removal after address (diff) | |
| download | tgif-cc9075067776ebd34cc08f31bf78bb05f12fd879.tar.xz | |
send-email: don't use Mail::Address, even if available
Using Mail::Address made sense when we didn't have a proper parser. We
now have a reasonable address parser, and using Mail::Address
_if available_ causes much more trouble than it gives benefits:
* Developers typically test one version, not both.
* Users may not be aware that installing Mail::Address will change the
behavior. They may complain about the behavior in one case without
knowing that Mail::Address is involved.
* Having this optional Mail::Address makes it tempting to anwser "please
install Mail::Address" to users instead of fixing our own code. We've
reached the stage where bugs in our parser should be fixed, not worked
around.
Signed-off-by: Matthieu Moy <git@matthieu-moy.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'notes.c')
0 files changed, 0 insertions, 0 deletions