diff options
author | Carlo Marcelo Arenas Belón <carenas@gmail.com> | 2020-05-02 15:34:47 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-05-02 18:10:38 -0700 |
commit | c03859a66525c6bdc5cd3c02b31f06cfdd80b595 (patch) | |
tree | 350a3dc97b28e87a7f34bc961997193263abf6b8 /notes.c | |
parent | credential-store: document the file format a bit more (diff) | |
download | tgif-c03859a66525c6bdc5cd3c02b31f06cfdd80b595.tar.xz |
credential-store: ignore bogus lines from store file
With the added checks for invalid URLs in credentials, any locally
modified store files which might have empty lines or even comments
were reported[1] failing to parse as valid credentials.
Instead of doing a hard check for credentials, do a soft one and
therefore avoid the reported fatal error.
While at it add tests for all known corruptions that are currently
ignored to keep track of them and avoid the risk of regressions.
[1] https://stackoverflow.com/a/61420852/5005936
Reported-by: Dirk <dirk@ed4u.de>
Helped-by: Eric Sunshine <sunshine@sunshineco.com>
Helped-by: Junio C Hamano <gitster@pobox.com>
Based-on-patch-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'notes.c')
0 files changed, 0 insertions, 0 deletions