diff options
| author |  Johannes Sixt <j6t@kdbg.org> | 2013-09-04 09:24:47 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2013-09-04 10:35:25 -0700 |
| commit | df17e77c0aacca35eaaac885fe70d97654c07d62 (patch) | |
| tree | 111bb8c6f1cdf0645ade368faf0b2c6c86ceda06 /notes-cache.h | |
| parent | Git 1.8.4 (diff) | |
| download | tgif-df17e77c0aacca35eaaac885fe70d97654c07d62.tar.xz | |
add--interactive: fix external command invocation on Windows
Back in 21e9757e (Hack git-add--interactive to make it work with
ActiveState Perl, 2007-08-01), the invocation of external commands was
changed to use qx{} on Windows. The rationale was that the command
interpreter on Windows is not a POSIX shell, but rather Windows's CMD.
That patch was wrong to include 'msys' in the check whether to use qx{}
or not: 'msys' identifies MSYS perl as shipped with Git for Windows,
which does not need the special treatment; qx{} should be used only with
ActiveState perl, which is identified by 'MSWin32'.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'notes-cache.h')
0 files changed, 0 insertions, 0 deletions