summaryrefslogtreecommitdiff
path: root/mergetools
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2020-08-14 12:14:14 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-08-14 10:52:04 -0700
commit9101c8ea2db466cce6d7d419d48e0516c6118813 (patch)
tree60de998ff32bec753314aa306d065369a66bb7c7 /mergetools
parentclear_pattern_list(): clear embedded hashmaps (diff)
downloadtgif-9101c8ea2db466cce6d7d419d48e0516c6118813.tar.xz
submodule--helper: use strbuf_release() to free strbufs
The prepare_to_clone_next_submodule() function has a few local-variable strbufs. We use strbuf_reset() throughout the function to reuse the buffers over and over. But at the end of the function we also use strbuf_reset() as they go out of scope, which means we end up leaking their heap buffers. This should be strbuf_release() instead. These were introduced by 48308681b0 (git submodule update: have a dedicated helper for cloning, 2016-02-29), but it doesn't seem to have the same mistake elsewhere. Likewise, I looked for other instances of the pattern in the submodule--helper file but couldn't find any. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'mergetools')
0 files changed, 0 insertions, 0 deletions