diff options
| author |  Elijah Newren <newren@gmail.com> | 2018-04-19 10:58:01 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-04-20 10:44:15 +0900 |
| commit | 9cfee25a823d972250409b5c8bdfd91d1cdf7edb (patch) | |
| tree | c580afccd831a82c31b8a2fb0a3500ac9847f4c2 /merge-recursive.c | |
| parent | merge-recursive: introduce new functions to handle rename logic (diff) | |
| download | tgif-9cfee25a823d972250409b5c8bdfd91d1cdf7edb.tar.xz | |
merge-recursive: fix leaks of allocated renames and diff_filepairs
get_renames() has always zero'ed out diff_queued_diff.nr while only
manually free'ing diff_filepairs that did not correspond to renames.
Further, it allocated struct renames that were tucked away in the
return string_list. Make sure all of these are deallocated when we
are done with them.
Reviewed-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'merge-recursive.c')
| -rw-r--r-- | merge-recursive.c | 20 |
1 files changed, 15 insertions, 5 deletions
diff --git a/merge-recursive.c b/merge-recursive.c index 40e142efdb..fc96653f63 100644 --- a/merge-recursive.c +++ b/merge-recursive.c @@ -1663,13 +1663,23 @@ static int handle_renames(struct merge_options *o, return process_renames(o, ri->head_renames, ri->merge_renames); } -static void cleanup_renames(struct rename_info *re_info) +static void cleanup_rename(struct string_list *rename) { - string_list_clear(re_info->head_renames, 0); - string_list_clear(re_info->merge_renames, 0); + const struct rename *re; + int i; - free(re_info->head_renames); - free(re_info->merge_renames); + for (i = 0; i < rename->nr; i++) { + re = rename->items[i].util; + diff_free_filepair(re->pair); + } + string_list_clear(rename, 1); + free(rename); +} + +static void cleanup_renames(struct rename_info *re_info) +{ + cleanup_rename(re_info->head_renames); + cleanup_rename(re_info->merge_renames); } static struct object_id *stage_oid(const struct object_id *oid, unsigned mode) |