summaryrefslogtreecommitdiff
path: root/mailinfo.h
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2017-01-09 01:00:12 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-01-09 01:29:50 -0800
commit007ac544011213045e3905983b4350ffec8f41f7 (patch)
treea65a572c581f00418229920f40868af9b8c8a344 /mailinfo.h
parentgit_exec_path: avoid Coverity warning about unfree()d result (diff)
downloadtgif-007ac544011213045e3905983b4350ffec8f41f7.tar.xz
git_exec_path: do not return the result of getenv()
The result of getenv() is not guaranteed by POSIX to last beyond another call to getenv(), or setenv(), etc. We should duplicate the string before returning to the caller to avoid any surprises. We already keep a cached pointer to avoid repeatedly leaking the result of system_path(). We can use the same pointer here to avoid allocating and leaking for each call. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'mailinfo.h')
0 files changed, 0 insertions, 0 deletions