diff options
author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | 2007-07-04 15:36:01 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2007-07-05 22:16:28 -0700 |
commit | 8c1ce0f46b85d40f215084eed7313896300082df (patch) | |
tree | 6b53a8be6d9c755f0b64c00ad920b318f770412b /local-fetch.c | |
parent | Add -v|--verbose to git remote to show remote url (diff) | |
download | tgif-8c1ce0f46b85d40f215084eed7313896300082df.tar.xz |
filter-branch: fail gracefully when a filter fails
A common mistake is to provide a filter which fails unwantedly. For
example, this will stop in the middle:
git filter-branch --env-filter '
test $GIT_COMMITTER_EMAIL = xyz &&
export GIT_COMMITTER_EMAIL = abc' rewritten
When $GIT_COMMITTER_EMAIL is not "xyz", the test fails, and consequently
the whole filter has a non-zero exit status. However, as demonstrated
in this example, filter-branch would just stop, and the user would be
none the wiser.
Also, a failing msg-filter would not have been caught, as was the
case with one of the tests.
This patch fixes both issues, by paying attention to the exit status
of msg-filter, and by saying what failed before exiting.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'local-fetch.c')
0 files changed, 0 insertions, 0 deletions