summaryrefslogtreecommitdiff
path: root/list-objects.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2018-11-02 01:22:59 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-11-02 20:49:52 +0900
commitb4cfcde4db8f5787c6c8a3912b0f2667becd1995 (patch)
tree70c0443f5cd536fc7daa1979893d6c9683eb5e34 /list-objects.c
parentEighth batch for 2.20 (diff)
downloadtgif-b4cfcde4db8f5787c6c8a3912b0f2667becd1995.tar.xz
rev-list: handle flags for --indexed-objects
When a traversal sees the --indexed-objects option, it adds all blobs and valid cache-trees from the index to the traversal using add_index_objects_to_pending(). But that function totally ignores its flags parameter! That means that doing: git rev-list --objects --indexed-objects and git rev-list --objects --not --indexed-objects produce the same output, because we ignore the UNINTERESTING flag when walking the index in the second example. Nobody noticed because this feature was added as a way for tools like repack to increase their coverage of reachable objects, meaning it would only be used like the first example above. But since it's user facing (and because the documentation describes it "as if the objects are listed on the command line"), we should make sure the negative case behaves sensibly. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'list-objects.c')
0 files changed, 0 insertions, 0 deletions