diff options
| author | Junio C Hamano <gitster@pobox.com> | 2016-10-12 11:20:23 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-10-12 11:22:10 -0700 |
| commit | 13092a916d7b8211fd828a6a7ee0d3cefff995e1 (patch) | |
| tree | edec0c5d32630cb5f78e06f8b0743199c503fcdd /imap-send.c | |
| parent | 74eeaf7b72a94bd3e0ff275edb90e6ee2423b529 (diff) | |
cocci: refactor common patterns to use xstrdup_or_null()
d64ea0f83b ("git-compat-util: add xstrdup_or_null helper",
2015-01-12) added a handy wrapper that allows us to get a duplicate
of a string or NULL if the original is NULL, but a handful of
codepath predate its introduction or just weren't aware of it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'imap-send.c')
| -rw-r--r-- | imap-send.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/imap-send.c b/imap-send.c index 0f5f4760e9..9514ddc565 100644 --- a/imap-send.c +++ b/imap-send.c @@ -1082,10 +1082,8 @@ static struct imap_store *imap_open_store(struct imap_server_conf *srvc, char *f cred.protocol = xstrdup(srvc->use_ssl ? "imaps" : "imap"); cred.host = xstrdup(srvc->host); - if (srvc->user) - cred.username = xstrdup(srvc->user); - if (srvc->pass) - cred.password = xstrdup(srvc->pass); + cred.username = xstrdup_or_null(srvc->user); + cred.password = xstrdup_or_null(srvc->pass); credential_fill(&cred); |