diff options
author | René Scharfe <l.s.r@web.de> | 2017-04-18 17:57:42 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-04-18 19:57:41 -0700 |
commit | da25bdb7766c01665500cf7c7b75e76ea1f28b49 (patch) | |
tree | 0130260984ed75f313cacb0fb1c452ce6f47dcf1 /ident.c | |
parent | preparing for 2.10.3 (diff) | |
download | tgif-da25bdb7766c01665500cf7c7b75e76ea1f28b49.tar.xz |
use HOST_NAME_MAX to size buffers for gethostname(2)
POSIX limits the length of host names to HOST_NAME_MAX. Export the
fallback definition from daemon.c and use this constant to make all
buffers used with gethostname(2) big enough for any possible result
and a terminating NUL.
Inspired-by: David Turner <dturner@twosigma.com>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: David Turner <dturner@twosigma.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ident.c')
-rw-r--r-- | ident.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -120,7 +120,7 @@ static int canonical_name(const char *host, struct strbuf *out) static void add_domainname(struct strbuf *out, int *is_bogus) { - char buf[1024]; + char buf[HOST_NAME_MAX + 1]; if (gethostname(buf, sizeof(buf))) { warning_errno("cannot get host name"); |