summaryrefslogtreecommitdiff
path: root/help.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2012-12-15 12:42:10 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2012-12-15 10:45:59 -0800
commita469a1019352b8efc4bd7003b0bd59eb60fc428c (patch)
tree33246362997de827418a21c7d0a7530b2d92e6f8 /help.c
parentmake error()'s constant return value more visible (diff)
downloadtgif-a469a1019352b8efc4bd7003b0bd59eb60fc428c.tar.xz
silence some -Wuninitialized false positives
There are a few error functions that simply wrap error() and provide a standardized message text. Like error(), they always return -1; knowing that can help the compiler silence some false positive -Wuninitialized warnings. One strategy would be to just declare these as inline in the header file so that the compiler can see that they always return -1. However, gcc does not always inline them (e.g., it will not inline opterror, even with -O3), which renders our change pointless. Instead, let's follow the same route we did with error() in the last patch, and define a macro that makes the constant return value obvious to the compiler. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'help.c')
0 files changed, 0 insertions, 0 deletions