diff options
| author |  Petr Baudis <pasky@suse.cz> | 2006-10-24 02:39:14 +0200 |
|---|---|---|
| committer |  Junio C Hamano <junkio@cox.net> | 2006-10-23 19:21:05 -0700 |
| commit | a153adf683d2b6e22c7e892ed8a161b140156186 (patch) | |
| tree | ddd2c5f05bc6ad23ff4512fd706a5984c75ba3ac /gitweb | |
| parent | daemon: do not die on older clients. (diff) | |
| download | tgif-a153adf683d2b6e22c7e892ed8a161b140156186.tar.xz | |
gitweb: Fix setting $/ in parse_commit()
If the commit couldn't have been read, $/ wasn't restored to \n properly,
causing random havoc like git_get_ref_list() returning the ref names with
trailing \n.
Aside of potential confusion in the body of git_search(), no other $/
surprises are hopefully hidden in the code.
Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'gitweb')
| -rwxr-xr-x | gitweb/gitweb.perl | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 23b26a2db2..2390603e97 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -1009,12 +1009,11 @@ sub parse_commit { if (defined $commit_text) { @commit_lines = @$commit_text; } else { - $/ = "\0"; + local $/ = "\0"; open my $fd, "-|", git_cmd(), "rev-list", "--header", "--parents", "--max-count=1", $commit_id or return; @commit_lines = split '\n', <$fd>; close $fd or return; - $/ = "\n"; pop @commit_lines; } my $header = shift @commit_lines; |