diff options
| author |  Robert Luberda <robert@debian.org> | 2019-10-27 10:14:26 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-10-28 11:06:57 +0900 |
| commit | 52bd3e46574baecf06562d4da857ba445981beb9 (patch) | |
| tree | 3c61638bec9354e9a5877eb1ce3f2cbbd70624af /gitweb/static/js | |
| parent | Git 2.23 (diff) | |
| download | tgif-52bd3e46574baecf06562d4da857ba445981beb9.tar.xz | |
gitweb: correctly store previous rev in javascript-actions mode
Without this change, the setting
$feature{'javascript-actions'}{'default'} = [1];
in gitweb.conf breaks gitweb's blame page: clicking on line numbers
displayed in the second column on the page has no effect.
For comparison, with javascript-actions disabled, clicking on line
numbers loads the previous version of the line.
Addresses https://bugs.debian.org/741883.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Robert Luberda <robert@debian.org>
Acked-by: Jakub Narębski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gitweb/static/js')
| -rw-r--r-- | gitweb/static/js/blame_incremental.js | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gitweb/static/js/blame_incremental.js b/gitweb/static/js/blame_incremental.js index db6eb50584..e100d8206b 100644 --- a/gitweb/static/js/blame_incremental.js +++ b/gitweb/static/js/blame_incremental.js @@ -484,7 +484,7 @@ function processBlameLines(lines) { case 'previous': curCommit.nprevious++; // store only first 'previous' header - if (!'previous' in curCommit) { + if (!('previous' in curCommit)) { var parts = data.split(' ', 2); curCommit.previous = parts[0]; curCommit.file_parent = unquote(parts[1]); |