summaryrefslogtreecommitdiff
path: root/gitweb.cgi
diff options
context:
space:
mode:
authorLibravatar Kay Sievers <kay.sievers@suse.de>2006-01-17 03:50:20 +0100
committerLibravatar Kay Sievers <kay.sievers@suse.de>2006-01-17 03:50:20 +0100
commit2c5c008b462fd5d2e32318077aaa3bc4e67c84fd (patch)
treec18277c5278f84a0ad3b94cef68cec2f4a28630e /gitweb.cgi
parentv263 (diff)
downloadtgif-2c5c008b462fd5d2e32318077aaa3bc4e67c84fd.tar.xz
fix: Use of uninitialized value
The subroutine did not check the case where HEAD does not verify. Patch from Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'gitweb.cgi')
-rwxr-xr-xgitweb.cgi9
1 files changed, 5 insertions, 4 deletions
diff --git a/gitweb.cgi b/gitweb.cgi
index 986d7dacd6..cb033733b9 100755
--- a/gitweb.cgi
+++ b/gitweb.cgi
@@ -404,12 +404,13 @@ sub git_read_head {
if (open my $fd, "-|", "$gitbin/git-rev-parse", "--verify", "HEAD") {
my $head = <$fd>;
close $fd;
- chomp $head;
- if ($head =~ m/^[0-9a-fA-F]{40}$/) {
- $retval = $head;
+ if (defined $head && $head =~ /^([0-9a-fA-F]{40})$/) {
+ $retval = $1;
}
}
- $ENV{'GIT_DIR'} = $oENV;
+ if (defined $oENV) {
+ $ENV{'GIT_DIR'} = $oENV;
+ }
return $retval;
}