summaryrefslogtreecommitdiff
path: root/gitk-git
diff options
context:
space:
mode:
authorLibravatar Ramkumar Ramachandra <artagnon@gmail.com>2011-08-04 16:09:02 +0530
committerLibravatar Junio C Hamano <gitster@pobox.com>2011-08-04 15:40:42 -0700
commita2ec3ad28f4608bc848feaa3d087632e44842dbf (patch)
tree44f649c964f0f2f2b27c2f7ffff513ef361a72f4 /gitk-git
parentrevert: Simplify and inline add_message_to_msg (diff)
downloadtgif-a2ec3ad28f4608bc848feaa3d087632e44842dbf.tar.xz
revert: Don't check lone argument in get_encoding
The only place get_encoding uses the global "commit" variable is when writing an error message explaining that its lone argument was NULL. Since the function's only caller ensures that a NULL argument isn't passed, we can remove this check with two beneficial consequences: 1. Since the function doesn't use the global "commit" variable any more, it won't need to change when we eliminate the global variable later in the series. 2. Translators no longer need to localize an error message that will never be shown. Suggested-by: Junio C Hamano <gitster@pobox.com> Mentored-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gitk-git')
0 files changed, 0 insertions, 0 deletions