summaryrefslogtreecommitdiff
path: root/git-gui
diff options
context:
space:
mode:
authorLibravatar Taylor Blau <me@ttaylorr.com>2020-01-30 15:00:43 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-01-31 12:47:40 -0800
commit1793280e91c51d5923e1c714ed6e0cd1291cbe77 (patch)
tree60119f40e4b818bf570a2a77f7e38f00d099c23b /git-gui
parentGit 2.25 (diff)
downloadtgif-1793280e91c51d5923e1c714ed6e0cd1291cbe77.tar.xz
t5318: don't pass non-object directory to '--object-dir'
In f237c8b6fe (commit-graph: implement git-commit-graph write, 2018-04-02) the test t5318.3 was introduced to ensure that calling 'git commit-graph write' in a repository with no packfiles does not write any commit-graph file(s). To exercise more paths in 'builtin/commit-graph.c', this test passes '--object-dir' to 'git commit-graph write', but the given argument refers to the working copy, not the object directory. Since the commit-graph sub-commands currently swallow these errors, this does not result in a test failure. But, it is only lucky that the test ends with no commit-graphs, since there were none to begin with. In preparation for a future commit where an '--object-dir' argument that does not match a known object directory will print out a failure, let's fix the test to still use '--object-dir', but pass the correct location to the object store instead of '.'. Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-gui')
0 files changed, 0 insertions, 0 deletions