diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-03-07 13:48:52 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-03-07 13:27:39 -0800 |
commit | c4d1d526312a2dbe39c7997cb5a08cfce12f2427 (patch) | |
tree | 933d3ae40a18bf154a36d58d0276c288c188676e /git-gui/lib | |
parent | The eighth batch (diff) | |
download | tgif-c4d1d526312a2dbe39c7997cb5a08cfce12f2427.tar.xz |
tests: change some 'test $(git) = "x"' to test_cmp
Change some of the patterns in the test suite where we were hiding the
exit code from "git" by invoking it in a sub-shell within a "test"
expression to use temporary files and test_cmp instead.
These are not all the occurrences of this anti-pattern, but these in
particular hid issues where LSAN was dying, and I'd thus marked these
tests as passing under the linux-leaks CI job in past commits with
"TEST_PASSES_SANITIZE_LEAK=true". Let's deal with that by either
removing that marking, or skipping specific tests under
!SANITIZE_LEAK.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-gui/lib')
0 files changed, 0 insertions, 0 deletions