summaryrefslogtreecommitdiff
path: root/git-gui/lib/encoding.tcl
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2018-02-08 16:38:06 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-02-08 14:20:43 -0800
commit89a9f2c862db52d99e4dd78e799f4b36dac597ac (patch)
treeede885d3eaea0bbd1e88e10795c54789f5761de1 /git-gui/lib/encoding.tcl
parentFirst batch after 2.16 (diff)
downloadtgif-89a9f2c862db52d99e4dd78e799f4b36dac597ac.tar.xz
CodingGuidelines: mention "static" and "extern"
It perhaps goes without saying that file-local stuff should be marked static, but it does not hurt to remind people. Less obvious is that we are settling on "do not include extern in function declarations". It is already the default unless the function was previously declared static (but if you are following a static declaration with an unmarked one, you should think about why you are declaring the thing twice). And so it just becomes an extra noise-word in our header files. We used to give the opposite advice, so there are quite a few "extern" markers in early Git code. But this at least makes a concrete suggestion that we can follow going forward. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-gui/lib/encoding.tcl')
0 files changed, 0 insertions, 0 deletions