summaryrefslogtreecommitdiff
path: root/git-gui/lib/date.tcl
diff options
context:
space:
mode:
authorLibravatar Jens Lehmann <Jens.Lehmann@web.de>2012-09-01 17:27:06 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2012-09-02 21:13:50 -0700
commit50d89ad6542c8acafefa6d42f8b42dfa9b8fafe1 (patch)
tree15fdf8cce305fb0f82deb78c820f34c341a732f1 /git-gui/lib/date.tcl
parentfetch: use argv_array instead of hand-building arrays (diff)
downloadtgif-50d89ad6542c8acafefa6d42f8b42dfa9b8fafe1.tar.xz
submodule: use argv_array instead of hand-building arrays
fetch_populated_submodules() allocates the full argv array it uses to recurse into the submodules from the number of given options plus the six argv values it is going to add. It then initializes it with those values which won't change during the iteration and copies the given options into it. Inside the loop the two argv values different for each submodule get replaced with those currently valid. However, this technique is brittle and error-prone (as the comment to explain the magic number 6 indicates), so let's replace it with an argv_array. Instead of replacing the argv values, push them to the argv_array just before the run_command() call (including the option separating them) and pop them from the argv_array right after that. Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-gui/lib/date.tcl')
0 files changed, 0 insertions, 0 deletions