summary refs log tree commit diff
path: root/git-compat-util.h
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2021-10-29 14:42:12 -0700
committerJunio C Hamano <gitster@pobox.com>2021-10-29 15:00:58 -0700
commita38989bd5bc850900667ae1b3c0cd43797b066f0 (patch)
treeb62ec1f246e8ddc5d7117adc1863f35507893e8d /git-compat-util.h
parentaf6d1d602a8f64164b266364339c4e936d5bbc33 (diff)
unsetenv(3) returns int, not void
This compatilibity implementation has been returning a wrong type,
ever since 731043fd (Add compat/unsetenv.c ., 2006-01-25) added to
the system, yet nobody noticed it in the past 16 years, presumably
because no code checks failures in their unsetenv() calls.  Sigh.

For now, make it always succeed.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-compat-util.h')
-rw-r--r--git-compat-util.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/git-compat-util.h b/git-compat-util.h
index b46605300a..0f7e369a5d 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -726,7 +726,7 @@ char *gitmkdtemp(char *);
 
 #ifdef NO_UNSETENV
 #define unsetenv gitunsetenv
-void gitunsetenv(const char *);
+int gitunsetenv(const char *);
 #endif
 
 #ifdef NO_STRCASESTR