summaryrefslogtreecommitdiff
path: root/generate-cmdlist.sh
diff options
context:
space:
mode:
authorLibravatar Jim Hill <gjthill@gmail.com>2014-12-21 11:26:00 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-12-22 10:27:42 -0800
commit3af74cfb153e20277a1d22414f04249d90d34d5c (patch)
tree29f7e45df9efd4b32bdda2c1ba0a28d6103d2787 /generate-cmdlist.sh
parentclean: typofix (diff)
downloadtgif-3af74cfb153e20277a1d22414f04249d90d34d5c.tar.xz
pre-push.sample: remove unnecessary and misleading IFS=' '
The sample hook explicitly sets IFS to SP and nothing else so that the "read" used in the per-ref while loop that iterates over "<localref> SP <localsha1> SP <remoteref> SP <remotesha>" records, where we know refs and sha1s will not have SPs, would split them correctly. While this is not wrong per-se, it is not necessary; because we know these fields do not contain HT or LF, either, we can simply leave IFS the default. This will also prevent those who cut and paste from this sample from getting bitten when they write things in the per-ref loop that need splitting with the default $IFS (e.g. use $(git rev-list ...) to produce one-record-per-line output). Signed-off-by: Jim Hill <gjthill@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'generate-cmdlist.sh')
0 files changed, 0 insertions, 0 deletions