diff options
author | Michael Haggerty <mhagger@alum.mit.edu> | 2012-09-09 08:19:42 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2012-09-12 11:46:31 -0700 |
commit | 4c58f13ba67f9dbe67a351de61703a2db20712cc (patch) | |
tree | 7dcf43f563e5291d4fef6f9a38a8de56933d0b17 /fetch-pack.h | |
parent | filter_refs(): do not check the same sought_pos twice (diff) | |
download | tgif-4c58f13ba67f9dbe67a351de61703a2db20712cc.tar.xz |
fetch_pack(): update sought->nr to reflect number of unique entries
fetch_pack() removes duplicates from the "sought" list, thereby
shrinking the list. But previously, the caller was not informed about
the shrinkage. This would cause a spurious error message to be
emitted by cmd_fetch_pack() if "git fetch-pack" is called with
duplicate refnames.
Instead, remove duplicates using string_list_remove_duplicates(),
which adjusts sought->nr to reflect the new length of the list.
The last test of t5500 inexplicably *required* "git fetch-pack" to
fail when fetching a list of references that contains duplicates;
i.e., it insisted on the buggy behavior. So change the test to expect
the correct behavior.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'fetch-pack.h')
0 files changed, 0 insertions, 0 deletions