diff options
author | Jeff King <peff@peff.net> | 2014-08-27 03:57:08 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-08-27 10:32:56 -0700 |
commit | c33ddc2e33d51da9391a81206a1d9e4a92d97d10 (patch) | |
tree | eb4a28190a98e436d07875d0785b21a27103f827 /diffcore-rename.c | |
parent | record_author_date(): use find_commit_header() (diff) | |
download | tgif-c33ddc2e33d51da9391a81206a1d9e4a92d97d10.tar.xz |
date: use strbufs in date-formatting functions
Many of the date functions write into fixed-size buffers.
This is a minor pain, as we have to take special
precautions, and frequently end up copying the result into a
strbuf or heap-allocated buffer anyway (for which we
sometimes use strcpy!).
Let's instead teach parse_date, datestamp, etc to write to a
strbuf. The obvious downside is that we might need to
perform a heap allocation where we otherwise would not need
to. However, it turns out that the only two new allocations
required are:
1. In test-date.c, where we don't care about efficiency.
2. In determine_author_info, which is not performance
critical (and where the use of a strbuf will help later
refactoring).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diffcore-rename.c')
0 files changed, 0 insertions, 0 deletions