summaryrefslogtreecommitdiff
path: root/diff.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2015-08-20 10:46:04 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-08-20 13:16:50 -0700
commit9f1429df179adb7a315616d01c9b237b521a3733 (patch)
tree455bded9f9cf71ccb3023df97d65eeadfd4c95bc /diff.c
parentconfig: restructure format_config() for better control flow (diff)
downloadtgif-9f1429df179adb7a315616d01c9b237b521a3733.tar.xz
format_config: don't init strbuf
It's unusual for a function which writes to a passed-in strbuf to call strbuf_init; that will throw away anything already there, leaking memory. In this case, there are exactly two callers; one relies on this initialization and the other passes in an already-initialized buffer. There's no leak, as the initialized buffer doesn't have anything in it. But let's bump the strbuf_init out to the one caller who needs it, making format_config more idiomatic. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diff.c')
0 files changed, 0 insertions, 0 deletions