diff options
| author |  Jeff King <peff@peff.net> | 2017-04-20 17:09:35 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2017-04-20 21:04:34 -0700 |
| commit | 16d2676c9ee996208277772fdf81dda212355440 (patch) | |
| tree | 74af8cd55456aa59bcc75fe4bfa715583461bc48 /convert.h | |
| parent | replace strbuf_addstr(git_path()) with git_path_buf() (diff) | |
| download | tgif-16d2676c9ee996208277772fdf81dda212355440.tar.xz | |
am: drop "dir" parameter from am_state_init
The only caller of this function passes in a static buffer
returned from git_path(). This looks dangerous at first
glance, but turns out to be OK because the first thing we do
is xstrdup() the result.
Let's turn this into a git_pathdup(). That's slightly more
efficient (no extra copy), and makes it easier to audit for
dangerous git_path() invocations.
Since there's only a single caller, let's just set this
default path inside the init function. That makes the memory
ownership clear.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'convert.h')
0 files changed, 0 insertions, 0 deletions