diff options
| author |  Jim Meyering <jim@meyering.net> | 2007-04-10 01:01:44 +0200 |
|---|---|---|
| committer |  Junio C Hamano <junkio@cox.net> | 2007-04-11 19:13:55 -0700 |
| commit | 6aead43db34313e6cdbc72e2f7a70f6b82c78cf2 (patch) | |
| tree | 6b07be3cba39adf0b1edeac27a1e73d16f3b4bb7 /convert-objects.c | |
| parent | Add testcase for format-patch --subject-prefix (take 3) (diff) | |
| download | tgif-6aead43db34313e6cdbc72e2f7a70f6b82c78cf2.tar.xz | |
sscanf/strtoul: parse integers robustly
* builtin-grep.c (strtoul_ui): Move function definition from here, to...
* git-compat-util.h (strtoul_ui): ...here, with an added "base" parameter.
* builtin-grep.c (cmd_grep): Update use of strtoul_ui to include base, "10".
* builtin-update-index.c (read_index_info): Diagnose an invalid mode integer
that is out of range or merely larger than INT_MAX.
(cmd_update_index): Use strtoul_ui, not sscanf.
* convert-objects.c (write_subdirectory): Likewise.
Signed-off-by: Jim Meyering <jim@meyering.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'convert-objects.c')
| -rw-r--r-- | convert-objects.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/convert-objects.c b/convert-objects.c index 4809f9199f..cf03bcfe5a 100644 --- a/convert-objects.c +++ b/convert-objects.c @@ -88,7 +88,7 @@ static int write_subdirectory(void *buffer, unsigned long size, const char *base unsigned int mode; char *slash, *origpath; - if (!path || sscanf(buffer, "%o", &mode) != 1) + if (!path || strtoul_ui(buffer, 8, &mode) != 1) die("bad tree conversion"); mode = convert_mode(mode); path++; |