summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2017-09-05 08:14:40 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2017-09-06 17:19:53 +0900
commitf5b4dc7668b6c8d71432af9f9ddad6f7c62d284e (patch)
tree08d66b7424d42dca854320d7a7e508800820c9e7 /contrib
parenttempfile: prefer is_tempfile_active to bare access (diff)
downloadtgif-f5b4dc7668b6c8d71432af9f9ddad6f7c62d284e.tar.xz
tempfile: handle NULL tempfile pointers gracefully
The tempfile functions all take pointers to tempfile objects, but do not check whether the argument is NULL. This isn't a big deal in practice, since the lifetime of any tempfile object is defined to last for the whole program. So even if we try to call delete_tempfile() on an already-deleted tempfile, our "active" check will tell us that it's a noop. In preparation for transitioning to a new system that loosens the "tempfile objects can never be freed" rule, let's tighten up our active checks: 1. A NULL pointer is now defined as "inactive" (so it will BUG for most functions, but works as a silent noop for things like delete_tempfile). 2. Functions should always do the "active" check before looking at any of the struct fields. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions