summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorLibravatar Stefan Beller <sbeller@google.com>2018-11-13 16:12:47 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-11-14 17:22:40 +0900
commitafd69dcc21972d766211ac253af2c18384e93056 (patch)
tree7ead2fbeba246f9c50a191d1797dcad11ca33eb4 /contrib
parentobject-store: allow read_object_file_extended to read from any repo (diff)
downloadtgif-afd69dcc21972d766211ac253af2c18384e93056.tar.xz
object-store: prepare read_object_file to deal with any repo
As read_object_file is a widely used function (which is also regularly used in new code in flight between master..pu), changing its signature is painful is hard, as other series in flight rely on the original signature. It would burden the maintainer if we'd just change the signature. Introduce repo_read_object_file which takes the repository argument, and hide the original read_object_file as a macro behind NO_THE_REPOSITORY_COMPATIBILITY_MACROS, similar to e675765235 (diff.c: remove implicit dependency on the_index, 2018-09-21) Add a coccinelle patch to convert existing callers, but do not apply the resulting patch to keep the diff of this patch small. Signed-off-by: Stefan Beller <sbeller@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
-rw-r--r--contrib/coccinelle/the_repository.pending.cocci12
1 files changed, 12 insertions, 0 deletions
diff --git a/contrib/coccinelle/the_repository.pending.cocci b/contrib/coccinelle/the_repository.pending.cocci
new file mode 100644
index 0000000000..a7ac9e0c46
--- /dev/null
+++ b/contrib/coccinelle/the_repository.pending.cocci
@@ -0,0 +1,12 @@
+// This file is used for the ongoing refactoring of
+// bringing the index or repository struct in all of
+// our code base.
+
+@@
+expression E;
+expression F;
+expression G;
+@@
+- read_object_file(
++ repo_read_object_file(the_repository,
+ E, F, G)