diff options
| author |  Sibo Dong <sibo.dong@outlook.com> | 2020-10-31 22:09:46 +0000 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-11-01 16:22:11 -0800 |
| commit | 9542d56379b60bb97d17ae1d1c8e8e4bc1fd65a3 (patch) | |
| tree | 35f4701ef65fe2d8617b65d9f4668cd312204a7f /contrib | |
| parent | Git 2.29.2 (diff) | |
| download | tgif-9542d56379b60bb97d17ae1d1c8e8e4bc1fd65a3.tar.xz | |
git-prompt.sh: localize `option` in __git_ps1_show_upstream
The variable 'option' is used in __git_ps1_show_upstream()
without being localized.
This clobbers the variable the user may be using for other
purposes, which is bad. Luckily, $option is not used to carry
information around in the script as a global variable. The use
of it in this script has very limited scope (namely, only inside
this function), so just declare that it is "local".
Signed-off-by: Sibo Dong <sibo.dong@outlook.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/completion/git-prompt.sh | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh index 16260bab73..5116016d39 100644 --- a/contrib/completion/git-prompt.sh +++ b/contrib/completion/git-prompt.sh @@ -137,6 +137,7 @@ __git_ps1_show_upstream () done <<< "$output" # parse configuration values + local option for option in ${GIT_PS1_SHOWUPSTREAM}; do case "$option" in git|svn) upstream="$option" ;; |