diff options
| author |  Johan Herland <johan@herland.net> | 2014-11-12 01:40:16 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-11-14 13:33:09 -0800 |
| commit | 908a3203632a02568df230c0fccf9a2cd8da24e6 (patch) | |
| tree | d67a27c86a1ebe5eaaca30441bd4e6bd96ae3fa1 /contrib | |
| parent | notes: empty notes should be shown by 'git log' (diff) | |
| download | tgif-908a3203632a02568df230c0fccf9a2cd8da24e6.tar.xz | |
t3301: modernize style
Make this test script appear somewhat less old-fashioned:
- Use test helper functions:
- write_script
- test_commit
- test_write_lines
- test_line_count
- test_config
- test_unconfig
- test_path_is_missing
- Remove whitespace between redirection operators and their targets.
- Move preparation of "expect" files into tests.
- Rename "output" files to "actual".
- More consistent quoting, especially around commands that might
expand to nothing.
- More visibility of important whitespace with ${indent}.
- Combine pairs of tests that unnecessarily split setup and verification.
Improved-by: Eric Sunshine <sunshine@sunshineco.com>
Improved-by: Junio C Hamano <gitster@pobox.com>
Improved-by: Michael Blume <blume.mike@gmail.com>
Improved-by: Jeff King <peff@peff.net>
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions