summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2021-04-28 11:42:30 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-04-29 10:03:46 +0900
commit1e951c647365be2e93bceddf7bd13173ed2cb1ce (patch)
tree51b69bcd12342bd618e41bc73afab7b06c1cf4d5 /contrib
parentGit 2.31.1 (diff)
downloadtgif-1e951c647365be2e93bceddf7bd13173ed2cb1ce.tar.xz
pack-bitmap: clean up include_check after use
When a bitmap walk has to traverse (to fill in non-bitmapped objects), we use rev_info's include_check mechanism to let us stop the traversal early. But after setting the function and its data parameter, we never clean it up. This means that if the rev_info is used for a subsequent traversal without bitmaps, it will unexpectedly call into our include_check function (worse, it will do so pointing to a now-defunct stack variable in include_check_data, likely resulting in a segfault). There's no code which does this now, but it's an accident waiting to happen. Let's clean up after ourselves in the bitmap code. Reported-by: David Emett <dave@sp4m.net> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
0 files changed, 0 insertions, 0 deletions