summaryrefslogtreecommitdiff
path: root/contrib/scalar/t/Makefile
diff options
context:
space:
mode:
authorLibravatar Phillip Wood <phillip.wood@dunelm.org.uk>2022-02-22 18:53:33 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2022-02-23 13:30:06 -0800
commitf7da756566e8abf18abdf9e30a8ed6d2088770de (patch)
treef92ab4f386d1bc5d1fb64314edc0c50f2f77c5d7 /contrib/scalar/t/Makefile
parentterminal: always reset terminal when reading without echo (diff)
downloadtgif-f7da756566e8abf18abdf9e30a8ed6d2088770de.tar.xz
terminal: pop signal handler when terminal is restored
When disable_bits() changes the terminal attributes it uses sigchain_push_common() to restore the terminal if a signal is received before restore_term() is called. However there is no corresponding call to sigchain_pop_common() when the settings are restored so the signal handler is left on the sigchain stack. This leaves the stack unbalanced so code such as sigchain_push_common(my_handler); ... read_key_without_echo(...); ... sigchain_pop_common(); pops the handler pushed by disable_bits() rather than the one it intended to. Additionally "git add -p" changes the terminal settings every time it reads a key press so the stack can grow significantly. In order to fix this save_term() now sets up the signal handler so restore_term() can unconditionally call sigchain_pop_common(). There are no callers of save_term() outside of terminal.c as the only external caller was removed by e3f7e01b50 ("Revert "editor: save and reset terminal after calling EDITOR"", 2021-11-22). Any future callers of save_term() should benefit from having the signal handler set up for them. Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/scalar/t/Makefile')
0 files changed, 0 insertions, 0 deletions