summaryrefslogtreecommitdiff
path: root/contrib/mw-to-git/t
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2021-02-16 09:44:32 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-02-16 09:41:33 -0800
commit2ef579e261fcd85a4eb6e0ce98ee4a01625fc210 (patch)
treec9309bb2a6590875cdd87c223cc081e5d5ad8e2e /contrib/mw-to-git/t
parentexclude: add flags parameter to add_patterns() (diff)
downloadtgif-2ef579e261fcd85a4eb6e0ce98ee4a01625fc210.tar.xz
attr: do not respect symlinks for in-tree .gitattributes
The attributes system may sometimes read in-tree files from the filesystem, and sometimes from the index. In the latter case, we do not resolve symbolic links (and are not likely to ever start doing so). Let's open filesystem links with O_NOFOLLOW so that the two cases behave consistently. As a bonus, this means that git will not follow such symlinks to read and parse out-of-tree paths. In some cases this could have security implications, as a malicious repository can cause Git to open and read arbitrary files. It could already feed arbitrary content to the parser, but in certain setups it might be able to exfiltrate data from those paths (e.g., if an automated service operating on the malicious repo reveals its stderr to an attacker). Note that O_NOFOLLOW only prevents following links for the path itself, not intermediate directories in the path. At first glance, it seems like ln -s /some/path in-repo might still look at "in-repo/.gitattributes", following the symlink to "/some/path/.gitattributes". However, if "in-repo" is a symbolic link, then we know that it has no git paths below it, and will never look at its .gitattributes file. We will continue to support out-of-tree symbolic links (e.g., in $GIT_DIR/info/attributes); this just affects in-tree links. When a symbolic link is encountered, the contents are ignored and a warning is printed. POSIX specifies ELOOP in this case, so the user would generally see something like: warning: unable to access '.gitattributes': Too many levels of symbolic links Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/mw-to-git/t')
0 files changed, 0 insertions, 0 deletions