summaryrefslogtreecommitdiff
path: root/contrib/credential
diff options
context:
space:
mode:
authorLibravatar David Turner <dturner@twopensource.com>2015-11-30 17:47:42 -0500
committerLibravatar Jeff King <peff@peff.net>2015-12-01 18:19:35 -0500
commit8c24d832cdcc1602fb5c7e7295447f8043879bf7 (patch)
tree50777861810c9eb603e02e382a19c7050524ef06 /contrib/credential
parentMerge branch 'eg/p4-submit-catch-failure' into maint (diff)
downloadtgif-8c24d832cdcc1602fb5c7e7295447f8043879bf7.tar.xz
verify_pack: do not ignore return value of verification function
In verify_pack, a caller-supplied verification function is called. The function returns an int. If that return value is non-zero, verify_pack should fail. The only caller of verify_pack is in builtin/fsck.c, whose verify_fn returns a meaningful error code (which was then ignored). Now, fsck might return a different error code (with more detail). This would happen in the unlikely event that a commit or tree that is a valid git object but not a valid instance of its type gets into a pack. Signed-off-by: David Turner <dturner@twopensource.com> Signed-off-by: Jeff King <peff@peff.net>
Diffstat (limited to 'contrib/credential')
0 files changed, 0 insertions, 0 deletions