diff options
| author |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2018-10-23 03:51:49 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-10-24 14:48:00 +0900 |
| commit | c6f050a4349339f812cdc3131ce104057424f492 (patch) | |
| tree | b96f4e292ffcbfd808dc4209c5a0dade4a49e8f6 /contrib/credential/wincred | |
| parent | Fifth batch for 2.20 (diff) | |
| download | tgif-c6f050a4349339f812cdc3131ce104057424f492.tar.xz | |
mingw: load system libraries the recommended way
When we access IPv6-related functions, we load the corresponding system
library using the `LoadLibrary()` function, which is not the recommended
way to load system libraries.
In practice, it does not make a difference: the `ws2_32.dll` library
containing the IPv6 functions is already loaded into memory, so
LoadLibrary() simply reuses the already-loaded library.
Still, recommended way is recommended way, so let's use that instead.
While at it, also adjust the code in contrib/ that loads system libraries.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/credential/wincred')
| -rw-r--r-- | contrib/credential/wincred/git-credential-wincred.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/contrib/credential/wincred/git-credential-wincred.c b/contrib/credential/wincred/git-credential-wincred.c index 86518cd93d..5bdad41de1 100644 --- a/contrib/credential/wincred/git-credential-wincred.c +++ b/contrib/credential/wincred/git-credential-wincred.c @@ -75,7 +75,8 @@ static CredDeleteWT CredDeleteW; static void load_cred_funcs(void) { /* load DLLs */ - advapi = LoadLibrary("advapi32.dll"); + advapi = LoadLibraryExA("advapi32.dll", NULL, + LOAD_LIBRARY_SEARCH_SYSTEM32); if (!advapi) die("failed to load advapi32.dll"); |