diff options
author | Jeff King <peff@peff.net> | 2018-06-14 23:44:43 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-06-18 09:13:57 -0700 |
commit | 1140bf01ecf4a49c32b3c385dd782cd183e730af (patch) | |
tree | 9253363dc076c4cf88cc60b93d1706fd38f3f0c5 /contrib/contacts | |
parent | ewah_read_mmap: bounds-check mmap reads (diff) | |
download | tgif-1140bf01ecf4a49c32b3c385dd782cd183e730af.tar.xz |
ewah: adjust callers of ewah_read_mmap()
The return value of ewah_read_mmap() is now an ssize_t,
since we could (in theory) process up to 32GB of data. This
would never happen in practice, but a corrupt or malicious
.bitmap or index file could convince us to do so.
Let's make sure that we don't stuff the value into an int,
which would cause us to incorrectly move our pointer
forward. We'd always move too little, since negative values
are used for reporting errors. So the worst case is just
that we end up reporting a corrupt file, not an
out-of-bounds read.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/contacts')
0 files changed, 0 insertions, 0 deletions