summaryrefslogtreecommitdiff
path: root/contrib/buildsystems
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2013-04-05 01:28:10 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2013-04-05 10:31:09 -0700
commit61690bf4a1ad499a673995b92cd8ab51104a431c (patch)
treea3f7ec623aa37cd17dae7052ce6612b283efb5b5 /contrib/buildsystems
parentdiffcore-pickaxe: fix leaks in "log -S<block>" and "log -G<pattern>" (diff)
downloadtgif-61690bf4a1ad499a673995b92cd8ab51104a431c.tar.xz
diffcore-pickaxe: unify code for log -S/-G
The logic flow of has_changes() used for "log -S" and diff_grep() used for "log -G" are essentially the same. See if we have both sides that could be different in any interesting way, slurp the contents in core, possibly after applying textconv, inspect the contents, clean-up and report the result. The only difference between the two is how "inspect" step works. Unify this codeflow in a helper, pickaxe_match(), which takes a callback function that implements the specific "inspect" step. After removing the common scaffolding code from the existing has_changes() and diff_grep(), they each becomes such a callback function suitable for passing to pickaxe_match(). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/buildsystems')
0 files changed, 0 insertions, 0 deletions